-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React: Avoid 'Dynamic require of react is not possible' issue #28730
React: Avoid 'Dynamic require of react is not possible' issue #28730
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 11f43cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
1991726
to
c76facf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
c76facf
to
8f30c5c
Compare
Closes N/A
What I did
It closes an issue when Vitest runs portable stories. The following error occurs:
This issue at
tsup
seems to be related:egoist/tsup#927
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Manual testing is not necessary. Automated tests cover it.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-28730-sha-8f30c5c8
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-28730-sha-8f30c5c8 sandbox
or in an existing project withnpx storybook@0.0.0-pr-28730-sha-8f30c5c8 upgrade
.More information
0.0.0-pr-28730-sha-8f30c5c8
valentin/fix-dynamic-require-react-issue-in-vitest
8f30c5c8
1722243649
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28730
Greptile Summary
This pull request addresses the issue of dynamic require errors for React in Vitest by modifying import statements and dynamic imports.
code/lib/react-dom-shim/src/react-16.tsx
to use namespace imports forreact-dom
.code/lib/react-dom-shim/src/react-18.tsx
to use namespace imports for both React and ReactDOM, ensuring compatibility with Vitest.code/renderers/react/src/renderToCanvas.tsx
to dynamically importrenderElement
andunmountElement
from@storybook/react-dom-shim
within therenderToCanvas
function, preventing dynamic require errors.